Nate Bosch

Results 719 comments of Nate Bosch

Should we refuse to allow access to the `LibraryElement` if there are errors? Or should we add a new API to query for errors and leave it up to builder...

`URI_NOT_GENERATED` is not a safe thing to check for - it's hardcoded by certain file patterns and won't work in general for codegen that the analyzer isn't set up for...

cc @kevmoo - this would potentially solve the angular use case - I think the discussion was around an API to get a `ResolvedLibraryResult`.

There is no way currently to pass args to DDC. We could consider allowing arguments, but the UX will not be great because they can't be passed to the `entrypoint`...

> How does the Dart team test new language features with DDC and dart2js? Within the SDK we don't typically run through `build_runner` or `webdev` - we use much more...

> Are you guaranteed when testing No test can offer a 100% guarantee. We also run tests in the build system repo against bleeding edge SDKs to catch issues quickly.

I wonder if this has something to do with the fact that we're in a package cycle with `package:test`. This repros with this file in that package: ```dart import 'package:test/test.dart';...

I also see that when we are trying to compile to kernel for `test.vm.dill` the string `stream_channel` doesn't show up anywhere in an `--input-linked` argument. I strongly suspect this has...

I'd also prefer if there were a better way to silence these lints in the analyzer. Filed https://github.com/dart-lang/sdk/issues/34069 to see if we can avoid having to hack around lints in...

This should not be blocking. I think you can drop an `// ignore:` anywhere in the file and it's fine to repeat it. It might not be pretty, but I...