Resonance UI/UX issues

[tfuxu]

Here's the list of most bugs and issues I found after testing the latest release of Resonance:

UI Bugs & Issues:

~Resonance isn't designed for Adwaita light theme (tracked in #16, #14 and #15)~ Fixed in 901e76f

Show image

~Main window doesn't have a title (instead if fallbacks to executable name)~ Fixed in 528bdba

Show image

~Search and Sort buttons don't use the same style as main menu button~ Fixed in b8b46cf

Show image

There is a one pixel border between queue list and and playback view (sometimes noticeable also with dark theme)

Show image

Queue list gradient sometimes doesn't get updated

Show image

~Some animations are too rapid (eg. Go Back from album view)~ Fixed in 5f7fda3f2fc06faf9753c00680bdab74634dc14b

I think that the stack holding AlbumGridPage to AlbumDetailPage pages should use GTK_STACK_TRANSITION_TYPE_CROSSFADE transition instead of slide left transition.

UX Bugs & Issues:

For some reason after a reboot I need to re-add my music folder, as otherwise it will show this error if I try to play any track:

Error from element filesrc7: Error { domain: gst-resource-error-quark, code: 3, message: "Resource not found." }

Clicking too much in Tracks can trigger a main thread panic at:

already borrowed: BorrowMutError' in src/views/pages/tracks/track_page_row.rs:239:26

Only the first track gets enumerated in album view if track numbers aren't explicitly defined in metadata

Show image

This is how it looks in GNOME Music:

Other issues:

Resonance doesn't use its symbolic icon in GNOME system settings

I suppose that this isn't a bug, but something that needs to be actually implemented.

Show image

Sometimes you can encounter a GTK critical error (I'm not sure how to reproduce this):

Gtk-CRITICAL **: 21:18:57.205: gtk_widget_compute_point: assertion 'GTK_IS_WIDGET (widget)' failed

Resonance prints out debug messages in Flatpak release

Show image

[nate-xyz]

The Gtk CRITICAL errors typically occur when I'm constructing widgets at runtime, like in the album sidebar, detail page, and in the album card widgets. I think (?) this is error is from improperly freeing memory from the previous construction of the widget as I usually just set the adw bin to the new widget or null IIRC. I'm not really sure how to fix this as I'm not familiar with gtk memory management in rust (or in general)

[nate-xyz]

Can you open an individual issue for the re-adding music folder bug with more info? Is your folder on a different drive maybe?

[tfuxu]

The Gtk CRITICAL errors typically occur when I'm constructing widgets at runtime, like in the album sidebar, detail page, and in the album card widgets. I think (?) this is error is from improperly freeing memory from the previous construction of the widget as I usually just set the adw bin to the new widget or null IIRC. I'm not really sure how to fix this as I'm not familiar with gtk memory management in rust (or in general)

From what I remember you should be able to clear a widget from memory by just using g_object_unref

[tfuxu]

Can you open an individual issue for the re-adding music folder bug with more info? Is your folder on a different drive maybe?

Yes, it is on a separate drive, because my Linux installation is configured to use an NVMe for the system and an HDD drive for the home directory.

[13k]

Another issue would be remembering window position/size between launches.

I'm using the flatpak release and I don't know if it affects only flatpak build or if it's a general issue.

[13k]

Another issue is the auto-scrolling when clicking on an album or song (artist page). If the layout's width is small enough, the UI will keep jumping around and won't register any click events, so it won't play anything that was selected. This also happens on the default layout size, but it's rare.

Video

https://github.com/nate-xyz/resonance/assets/4762/f6337eb1-e4a2-48e0-9b40-1a60fd32b366

You can notice the currently playing song doesn't change.