picaso icon indicating copy to clipboard operation
picaso copied to clipboard

Add calculation input to justdoit.climate when `with_spec = True`

Open logan-pearce opened this issue 2 months ago • 2 comments

This line hard-codes in a thermal spectrum calculation, which gives an error if phase != 0. Recommend adding ability to take thermal/reflected calculation input

https://github.com/natashabatalha/picaso/blob/d48e4faade653be36a72197f23c3d6e8f0e3cfd8/picaso/justdoit.py#L5214

logan-pearce avatar Oct 24 '25 17:10 logan-pearce

This isn't impossible. But the reason we do this is that thermal is the only one that has common inputs with a climate calculation. transmission would require people to input mass/radius instead of just gravity required for climate and reflected would require people to input radius (for relative flux). So we still have that hard coded and force people to do it themselves after (especially since most of the time people want to swap the opacity file anyways before doing the full spectrum). We could add checks to the beginning so I'll leave this open in case others want it all in one go as well.

natashabatalha avatar Nov 17 '25 18:11 natashabatalha

I used to run climate with with_spec=True for reflected light calculation, which produced an error with phase != 0. But I switched to not bothering to run a spectrum after climate since I was switching the opacity file anyways later, as you said. So it's not critical.

logan-pearce avatar Nov 17 '25 19:11 logan-pearce