Natasha Sarkar
Natasha Sarkar
A bit of a clarification question, what exactly do we mean by 'package' resource? I'm imagining a resource that contains references to all of the package revisions that belong to...
Based on other discussion, I think the following makes sense: 1. Creating a new package will create an empty package with no package revisions or resources. Creating a package revision...
https://github.com/GoogleContainerTools/kpt/pull/3451 will surface the validation error. Do you mind taking a quick look to see if the format of the returned error works for you?
Per offline discussion, @droot will be taking over this by surfacing the function results in the API.
qq, do we plan to switch to go workspace mode as well?
cc @droot @mortent
I'll see if I can add a test for this
@mortent In addition to changing the output for porch, this PR changes the output slightly for `kpt fn render` and `kpt fn eval`. More details in https://github.com/GoogleContainerTools/kpt/pull/3451#discussion_r942756230 and https://github.com/GoogleContainerTools/kpt/pull/3451#discussion_r942924045. I...
> @natasha41575 These changes seem fine to me, but I think we want @droot or @mengqiy to verify this. 👍 Will ask @droot to take a look when he comes...
Chatted with @droot offline about this. This PR tries to expose the fnResults as a string in the error message, but that doesn't make sense as a porch API. We...