Mattia Iavarone
Mattia Iavarone
I would do this: 1. create a new sealed class for the camera state, something like: ``` sealed class CameraState { class Closed : CameraState() class Open : CameraState() class...
Thanks for the clear description! The proposed solution sounds good to me. Would you like to work on it?
What happens if you basically remove all that you have done and simply change `CameraBaseEngine.setMode()` line 393? Instead of calling restart(), call restartBind(). And instead of `CameraState.ENGINE`, use `CameraState.BIND` in...
The issue with your solution is that the capture size is recomputed, but the preview size is not recomputed. But the preview size depends on the capture size... (we want...
For example because someone might call: ```java camera.setPictureSize(SizeSelectors.aspectRatio(16/9)); camera.setVideoSize(SizeSelectors.aspectRatio(4/3)); ``` and we want the preview to be 16:9 in the first case and 4:3 in the second case. But in...
I have nothing against the feature, but this PR has too much clutter, unneeded changes, no javadocs, no docs, no tests, no PR description about design decisions (e.g. I changed...
Will be possible in v2
Sorry to hear that but I don't have this device so there's nothing I can do.
@cpt23 could you try with this PR https://github.com/natario1/CameraView/pull/1020 ? Just merged into master. It fixes a similar issue on Pixel 4. To test, you have to modify the FpsRangeValidator class...
@cpt23 so I should add "Google Pixel 5" to FpsRangeValidator right? Or did it fix the issue even without that change?