Transcoder Library completely broken since 0.10.0 on some devices

Library completely broken since 0.10.0 on some devices

Open alaegin opened this issue 3 years ago • 3 comments

Hello! We have just started to use this library and realized that it's completely broken on some devices since 0.10.0.

Prerequisites:

CameraView library for video recording. Default settings with Camera2 Engine.
OnePlus 5 and OnePlus 7 Pro. Both use Android 10. (Also tested on Honor 9X (STK-LX1) and it works fine there).

The main problem is that the library crashes unexpectedly in some cases or transcode video with artifacts.

0.9.1 works fine
0.10.0 - 0.10.2 print Validator has decided that the input is fine and transcoding is not necessary. and don't transcode video at all. Link
0.10.3 fails with several random issues listed below

We have several cases:

Library crashes with exception java.lang.IllegalStateException: Failed to stop the muxer. Link
Library crashes with exception TranscodeEngine: Unexpected error while transcoding. java.nio.BufferOverflowException. Link
Library transcode video with artifacts. Link to video

The code we use to call Transcoder:

Transcoder.into(filesProvider.getTempResultFile().absolutePath)
    .apply {
        files.forEach { addDataSource(it.absolutePath) }
    }
    .setListener(...)
    .transcode().get()

It seems that rewriting #118 of the transcoder pipeline broke something important.