Eduard Tudenhoefner

Results 199 comments of Eduard Tudenhoefner

> @nastra I assume we are ready revive this work and this is ready for review? @stevenzwu yes I revived this work and it's ready for review. Note that I...

@wangyinsheng to fix CI failures I think you need to add the below code to `TransactionTable`: ``` @Override public MetricsReporter metricsReporter() { return BaseTransaction.this.reporter; } ``` and then also this...

@wangyinsheng I talked to @rdblue yesterday and we concluded that we don't want to carry over the catalog properties just for the metrics reporter. The better approach would be to...

@wangyinsheng as mentioned previously, we still would like to make the `MetricsReporter` `Serializable`. For things that aren't `Serializable` in a metrics reporter, we would make them `transient` and then lazily...

> @nastra, where are we with the fix for serialization here? @rdblue I haven't heard back from @wangyinsheng after [my comment above ](https://github.com/apache/iceberg/pull/7144#issuecomment-1519866237), so I've opened https://github.com/apache/iceberg/pull/7370 a while ago...

> @nastra I just wanted to understand the benefits of Awaitility in place of sleep With a fixed sleep in tests you might wait too long or too short for...

@gzagarwal you might want to talk to @coded9 as he also wanted to work on this, although I don't know the current state of this

I've opened https://github.com/apache/iceberg/pull/8853 and https://github.com/apache/iceberg/pull/8852 to give an idea about places that are good candidates to replace with Awaitility. I believe there are more similar places in the codebase that...

I think a few other places that would be good to address are all places that use https://github.com/apache/iceberg/blob/main/spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java#L331

I think it's fine reducing those scale factors, but it's quite interesting that this takes so long for you. I've ran `HadoopFileIOTest` a few times locally and it takes about...