3 failures and 5 errors when I run magic tests

[skydread1]

Problem

We used to have only the mutual-recursion error (issue #218), but now we have more errors and failures.

~/workspaces/magic-compiler/magic:nos test/all
Downloading GitHub Repo:  nasser/mage
Downloading GitHub Repo:  nasser/test.check

Testing magic.test.literals

Testing magic.test.data-structures

Testing magic.test.string

ERROR in (t-split) (:0)
expected: (clojure.core/= (= ["a" "b-c"] (clojure.string/split "a-b-c" #"-" 2)) (magic.api/eval (quote (= ["a" "b-c"] (clojure.string/split "a-b-c" #"-" 2)))))
  actual: System.InvalidCastException: Specified cast is not valid.
 at Magic.DelegateHelpers+<>c__DisplayClass12_3`4[[System.Text.RegularExpressions.Regex, System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.String[], mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].<GetMethodDelegateFast03>b__3 (:0)
    Magic.CallsiteInstanceMethod02.Invoke (:0)
    <magic>clojure_string$split__0.invokeTyped (:0)
    <magic>clojure_string$split__0.invoke (:0)
    <magic>magic_test_string$<fn>__0.invoke (:0)

Testing magic.test.logic

Testing magic.test.control

Testing magic.test.numbers

Testing magic.test.interop

ERROR in (zero-arity-instance-member) (:0)
Uncaught exception, not in assertion.
expected: nil
  actual: System.InvalidProgramException: Invalid IL code in <magic>magic_test_interop$<fn>__3:invoke (): IL_154b: call      0x0a00001c


 at <magic>clojure_test$test-var__0.invoke (:0)

Testing magic.test.special

FAIL in (do-expr) (:0)
expected: (clojure.core/= (do 1 2 3) (magic.api/eval (quote (do 1 2 3))))
  actual: (not (clojure.core/= 3 nil))

FAIL in (with-meta-exprs) (:0)
expected: (clojure.core/= (let [xx (* 9 Math/PI) jj [1 2 3 4]] (meta jj)) (magic.api/eval (quote (let [xx (* 9 Math/PI) jj [1 2 3 4]] (meta jj)))))
  actual: (not (clojure.core/= {:meta "data", :expr 28.2743338823081} nil))

FAIL in (with-meta-exprs) (:0)
expected: (clojure.core/= (let [jj [1 2 3 4]] (meta jj)) (magic.api/eval (quote (let [jj [1 2 3 4]] (meta jj)))))
  actual: (not (clojure.core/= {:meta "data"} nil))

Testing magic.test.dynamic

ERROR in (method-invocation) (:0)
expected: (clojure.core/= (.Substring (identity "hello") 2 3) (magic.api/eval (quote (.Substring (identity "hello") 2 3))))
  actual: System.InvalidCastException: Specified cast is not valid.
 at Magic.DelegateHelpers+<>c__DisplayClass12_3`4[[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].<GetMethodDelegateFast03>b__3 (:0)
    Magic.CallsiteInstanceMethod02.Invoke (:0)
    <magic>magic_test_dynamic$<fn>__1.invoke (:0)

ERROR in (method-invocation) (:0)
expected: (clojure.core/= (.Substring (identity "hello") 2.5 3.2) (magic.api/eval (quote (.Substring (identity "hello") 2.5 3.2))))
  actual: System.InvalidCastException: Specified cast is not valid.
 at Magic.DelegateHelpers+<>c__DisplayClass12_3`4[[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.Int32, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].<GetMethodDelegateFast03>b__3 (:0)
    Magic.CallsiteInstanceMethod02.Invoke (:0)
    <magic>magic_test_dynamic$<fn>__1.invoke (:0)

Testing magic.test.proxy

Testing magic.test.reify

Testing magic.test.fn

Testing magic.test.letfn

ERROR in (mutual-recursion) (:0)
expected: (clojure.core/= (letfn [(even2 [n] (neven? n)) (neven? [n] (if (zero? n) true (nodd? (dec n)))) (nodd? [n] (if (zero? n) false (neven? (dec n))))] [(even2 91) (even2 90)]) (magic.api/eval (quote (letfn [(even2 [n] (neven? n)) (neven? [n] (if (zero? n) true (nodd? (dec n)))) (nodd? [n] (if (zero? n) false (neven? (dec n))))] [(even2 91) (even2 90)]))))
  actual: System.NullReferenceException: Object reference not set to an instance of an object
 at <magic>magic_test_letfn$even2__0.invoke (:0)
    <magic>magic_test_letfn$<fn>__1.invoke (:0)

Ran 135 tests containing 1597 assertions.
3 failures, 5 errors.

How to reproduce

• Build last version of magic/nostrand using my pipeline fork skydread1/magic-pipeline/1-build-on-mac-fix

• verify versions:

~/workspaces/magic-compiler/magic:nos version
Downloading GitHub Repo:  nasser/mage
Downloading GitHub Repo:  nasser/test.check
Nostrand 1.0.0+e6ab32d3
Clojure.Runtime 1.10.0.0+3bd47b31
Magic.Runtime 1.0.0+33e9131a
Clojure 1.10.0-master-SNAPSHOT

nasser/magic commit when I cloned: 1199aeb175f30e5dfd0ecf0d65a354ac49747ab6

• run the test with nostrand:

~/workspaces/magic-compiler/magic:nos test/all