progpy icon indicating copy to clipboard operation
progpy copied to clipboard

cleanup PassthroughParams

Open teubert opened this issue 1 year ago • 1 comments

Update passthrough params to use the model index instead of making a copy of the model and remove models when calling super setstate (avoids unnecessary model deep copy).

teubert avatar Jul 12 '24 22:07 teubert

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • [ ] Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • [ ] Ensure that each PR adding a new feature should include a test verifying that feature.
  • [ ] All errors from static analysis must be resolved.
  • [ ] Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • [ ] Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • [ ] Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • [ ] All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

github-actions[bot] avatar Jul 12 '24 22:07 github-actions[bot]