openmct icon indicating copy to clipboard operation
openmct copied to clipboard

Cannot dismiss individual notifications — panel closes, notification remains

Open MiRGB opened this issue 6 months ago • 5 comments

Summary

Clicking the "Dismiss" (X) button on individual notifications (e.g. “Save successful”) does not remove that notification from the list. Instead, it closes the entire notification panel. This breaks the expected behavior and may confuse users who want to clear specific notifications without dismissing all or closing the panel.

Expected vs Current Behavior

Expected: Clicking the “Dismiss” (X) button should remove the specific notification from the list, while keeping the panel open.
Current: The entire notification panel closes, and the notification remains in the list.

Steps to Reproduce

  1. Open Open MCT
  2. Click “+ Create”, select any object (e.g., Clock)
  3. Click “OK” to save the object — this triggers a notification: “Save successful”
  4. Click “1 Notification” in the top bar to open the notification list
  5. Click the Dismiss button (HTML: button[aria-label="Dismiss notification of Save successful"])
  6. Observe that the panel closes and the notification is still present

Environment

  • Open MCT Version: 4.1.0-next
  • Build Date: Jun 25, 2025
  • Revision: f4637b8ac7b1b1b71c5082152a4d60c783971251
  • Deployment Type: npm dev
  • OS: Windows 10
  • Browser: Chrome (latest), Opera
  • Issue appears consistent across browsers/OS

Impact Check List

  • [ ] Data loss or misrepresented data?
  • [ ] Regression? Did this used to work or has it always been broken?
  • [x] Is there a workaround available? (User must manually clear all notifications)
  • [ ] Does this impact a critical component?
  • [x] Is this just a visual bug with no functional impact?
  • [ ] Does this block the execution of e2e tests?
  • [ ] Does this have an impact on Performance?

Additional Information

The issue is likely due to incorrect event handling — the dismiss button seems to trigger the same handler as the panel close button. A short screen recording and screenshots can be provided upon request.

This is the locator of the faulty button: button[aria-label="Dismiss notification of Save successful"]

Image

Bug reproduced in this video

https://github.com/user-attachments/assets/8f6858a5-7fca-4241-b504-2e3e81158bba

MiRGB avatar Jun 25 '25 02:06 MiRGB

Can this be assinged to me ?

ermahesh avatar Jun 25 '25 21:06 ermahesh

PR: https://github.com/nasa/openmct/pull/8130

vhenckel avatar Aug 11 '25 21:08 vhenckel

Thank you for fixing the reported issue — the functionality now works correctly.

However, I noticed a minor UI regression: the dismiss button has shifted position, which affects the layout of the notification panel. Additionally, the button appears slightly smaller than before. Would it be possible to adjust the CSS to restore it to its original placement and size?

Image

MiRGB avatar Aug 12 '25 02:08 MiRGB

@MiRGB https://github.com/nasa/openmct/pull/8130/commits/8a501e9c593f4afedf859e501a9c19fcc51b1525

vhenckel avatar Aug 12 '25 13:08 vhenckel

Thank you for the update.

I've tested the latest changes and can confirm that the UI regression has been resolved — the dismiss button is now correctly positioned and appears at its original size. Everything functions and looks as expected. Great work!

MiRGB avatar Aug 12 '25 15:08 MiRGB

Is this project still active? Does it still make sense to continue contributing to this project?

vhenckel avatar Dec 01 '25 13:12 vhenckel

The issue itself has been resolved and the fix was verified on my side. From my perspective, this can be considered complete. Thanks for the contribution!

MiRGB avatar Dec 18 '25 09:12 MiRGB