openmct icon indicating copy to clipboard operation
openmct copied to clipboard

Submitting time conductor without changes causes downstream side-effects

Open shefalijoshi opened this issue 11 months ago • 1 comments

Submit button for the time conductor popup should not trigger network requests if there are no changes made to the modes/time ranges.

Summary

Closing the time conductor popup using the submit button with no changes causes downstream side-effects (like network requests). Ideally the submit button should perform a noop (or something similar) if there are no changes to submit.

Expected vs Current Behavior

Pressing the submit button in the time conductor popup with no changes has downstream side effects. Work around is to press the X (close time popup) button instead.

Steps to Reproduce

  1. Load Open MCT with realtime and fixed time modes configured
  2. Change the mode from realtime to fixed time (or vice-versa) and observe that network requests are triggered to receive new data for the new settings.
  3. Now press the submit button in the pop up image
  4. Notice that network requests are triggered again to receive new data.

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • [ ] Data loss or misrepresented data?
  • [ ] Regression? Did this used to work or has it always been broken?
  • [x] Is there a workaround available?
  • [ ] Does this impact a critical component?
  • [ ] Is this just a visual bug with no functional impact?
  • [ ] Does this block the execution of e2e tests?
  • [x] Does this have an impact on Performance?

Additional Information

shefalijoshi avatar Mar 18 '24 22:03 shefalijoshi