openmct
openmct copied to clipboard
Fix overflow, alignment and padding in text and button elements
Closes #7540
Describe your changes:
- Adds
overflow: hidden
to Condition Widget label and alphanumeric wrappers. - Adds a simple and common SCSS mixin for text views (Hyperlink links and layout text drawing objects) that normalizes overflow, padding and alignment.
All Submissions:
- [x] Have you followed the guidelines in our Contributing document?
- [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
- [ ] Is this a notable change that will require a special callout in the release notes Notable Change ? For example, will this break compatibility with existing APIs or projects which source these plugins?
Author Checklist
- [x] Changes address original issue?
- [ ] Tests included and/or updated with changes?
- [x] Has this been smoke tested?
- [x] Have you associated this PR with a
type:
label? Note: this is not necessarily the same as the original issue. - [x] Have you associated a milestone with this PR? Note: leave blank if unsure.
- [ ] Is this a breaking change to be called out in the release notes?
- [x] Testing instructions included in associated issue OR is this a dependency/testcase change?
Reviewer Checklist
- [ ] Changes appear to address issue?
- [ ] Reviewer has tested changes by following the provided instructions?
- [ ] Changes appear not to be breaking changes?
- [ ] Appropriate automated tests included?
- [ ] Code style and in-line documentation are appropriate?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 56.20%. Comparing base (
5fc5c13
) to head (a8896a3
).
Additional details and impacted files
@@ Coverage Diff @@
## master #7541 +/- ##
==========================================
+ Coverage 56.16% 56.20% +0.03%
==========================================
Files 672 672
Lines 27112 27112
Branches 2635 2635
==========================================
+ Hits 15227 15237 +10
+ Misses 11560 11550 -10
Partials 325 325
Flag | Coverage Δ | |
---|---|---|
e2e-full | 23.60% <ø> (ø) |
|
e2e-stable | 59.99% <ø> (+0.02%) |
:arrow_up: |
unit | 49.14% <ø> (+0.01%) |
:arrow_up: |
see 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5fc5c13...a8896a3. Read the comment docs.
@unlikelyzero How can I help move this through? Should I add tests? I'm not sure how to check against what we already have vs. the delta for new.
All css changes have been approved by @davetsay and @charlesh88
@ozyx , I met with @charlesh88 and we discussed a simple test with 4 objects within a display layout: Hyperlink at minimum height (10px) Hyperlink at minimum width (20px) Layout Text at minimum height (10px) Layout Text at minimum width (20px)