[Gauge] Value range and limit indicators are broken

[rukmini-bose]

Summary

When a user manually enters high/low limits, the validity indicators (the red x or green check) that used to work, do not anymore. They stay showing invalid, regardless of whether the values a user inputs are valid or not. Additionally, when a user does enter an invalid limit, the OK button used to be disabled, disallowing users to save the Gauge until a valid value was inputted. This doesn't happen anymore– instead, users can save the object with invalid limits.

Notice in the picture below: The high limit of 90 IS valid if the maximum value is 100. However, the indicator shows it as invalid. Additionally, the low limit of -20 IS NOT valid if the minimum value is 0. The indicator shows it as invalid as well. Now notice that the OK button is not disabled, and allows for a user to save the changes.

Expected vs Current Behavior

Steps to Reproduce

1. Navigate to/ create a gauge.
2. Toggle off the ability to use Telemetry limits.
3. Manually enter in your own limits. Test with invalid and valid limits. For limits to be valid, the low limit must be higher than the minimum value and the high limit must be lower than the maximum. For a limit to be invalid, the lower limit should be less than the minimum, and upper limit should be more.
4. Observe that regardless of the limits being valid or not, the validity indicator stays invalid.
5. Observe that when you enter an invalid limit, you are still able to press OK and save the object.

Environment

• Open MCT Version: 2.2.1
• Deployment Type: Testathon
• OS:
• Browser: Chrome

Impact Check List

• [ ] Data loss or misrepresented data?
• [x] Regression? Did this used to work or has it always been broken?
• [x] Is there a workaround available?
• [x] Does this impact a critical component?
• [ ] Is this just a visual bug with no functional impact?
• [ ] Does this block the execution of e2e tests?
• [ ] Does this have an impact on Performance?

Additional Information

[unlikelyzero]

Note that this is a broken validation mechansim

[TheFuturist32]

Hey all, I looked into these issues and was able to fix them. It's not allowing me to push to origin though, permission denied error.

[ozyx]

Hey all, I looked into these issues and was able to fix them. It's not allowing me to push to origin though, permission denied error.

Awesome, thanks for looking into this. Please open a PR so we can review your changes. Also, you'll need to submit a CLA if you have not done so already. An approved CLA is needed before we can merge your code. We can still review in the meantime while we wait for that.