fprime icon indicating copy to clipboard operation
fprime copied to clipboard

Minor refactoring for LoggerRules.cpp

Open Anirban166 opened this issue 2 years ago • 2 comments

Originating Project/Creator @Anirban166
Affected Component Unit tests for Fw::Logger
Affected Architectures(s)
Related Issue(s) -/-
Has Unit Tests (y/n)
Builds Without Errors (y/n) y
Unit Tests Pass (y/n) y
Documentation Included (y/n) n


Change Description

Avoiding a bit of code duplication/repetition.

Rationale

To reduce code bloating!

Anirban166 avatar Aug 04 '22 06:08 Anirban166

@LeStarch were the argument-count-representing numbers for the print statements in lines 167, 171, 175, and 179 intentionally made 'Six' for the class/struct LogBad? (wondering if they're typos from copy-paste or a charactertistic that distinguishes the LogBad rule from LogGood, apart from the fact that the former only passes in a nullptr to the check method for the FakeLogger object)

Anirban166 avatar Aug 04 '22 07:08 Anirban166

Copy and paste error.

LeStarch avatar Aug 05 '22 00:08 LeStarch