earthdata-search
earthdata-search copied to clipboard
EDSC-3314: Display explore button with diabled state and tooltip
Overview
What is the feature?
This pr will help the explore button to be disabled along with a tooltip when parameters are invalid. solves https://github.com/nasa/earthdata-search/issues/1544
What is the Solution?
I have used react bootstrap's overlaytrigger component that will show tooltip only when the conditions are met. Similarly the dropdown toggle will be disabled.
What areas of the application does this impact?
Explore button
List impacted areas.
Testing
Reproduction steps
- Environment for testing:
- Collection to test with:
- Step 1
- Step 2...
Attachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Checklist
- [ ] I have added automated tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
Hi @macrouch is there any way i can test the changes locally?
Follow the README.md to get a local environment set up
Codecov Report
Merging #1554 (66a6a61) into master (4343414) will decrease coverage by
25.53%
. The diff coverage is25.00%
.
@@ Coverage Diff @@
## master #1554 +/- ##
===========================================
- Coverage 92.14% 66.61% -25.54%
===========================================
Files 698 698
Lines 17398 17398
Branches 4428 4426 -2
===========================================
- Hits 16032 11589 -4443
- Misses 1260 5161 +3901
- Partials 106 648 +542
Impacted Files | Coverage Δ | |
---|---|---|
...components/GranuleResults/GranuleResultsActions.js | 85.71% <25.00%> (-5.72%) |
:arrow_down: |
static/src/js/util/variables.js | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
static/src/js/util/isLinkType.js | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
serverless/src/getProject/handler.js | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
static/src/js/util/focusedGranule.js | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
serverless/src/alertLogger/handler.js | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
serverless/src/edlCallback/handler.js | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
serverless/src/errorLogger/handler.js | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
serverless/src/getColorMap/handler.js | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
serverless/src/getProjects/handler.js | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
... and 295 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Closing due to inactivity