earthdata-search icon indicating copy to clipboard operation
earthdata-search copied to clipboard

EDSC-3328:rename 'Available from AWS Cloud' facet to 'Available in Earthdata Cloud'

Open Vinitvh opened this issue 2 years ago • 3 comments

…rthdata Cloud'

Overview

What is the feature?

'Available from AWS Cloud' feature facet

What is the Solution?

Renamed 'Available from AWS Cloud' facet to 'Available in Earthdata Cloud'

What areas of the application does this impact?

-UI

Testing

Reproduction steps

  • Environment for testing:
  • Collection to test with:
  1. npm run test

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • [ ] I have added automated tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

Vinitvh avatar Sep 17 '22 04:09 Vinitvh

Codecov Report

Merging #1546 (b00a5e1) into master (95ffdd8) will decrease coverage by 6.70%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1546      +/-   ##
==========================================
- Coverage   92.22%   85.52%   -6.71%     
==========================================
  Files         686      686              
  Lines       17103    16702     -401     
  Branches     4378     4219     -159     
==========================================
- Hits        15774    14284    -1490     
- Misses       1229     2083     +854     
- Partials      100      335     +235     
Impacted Files Coverage Δ
static/src/js/components/Facets/Facets.js 100.00% <ø> (ø)
...CollectionDetails/CollectionDetailsFeatureGroup.js 0.00% <0.00%> (-100.00%) :arrow_down:
...ainers/GranuleFiltersContainer/mapPropsToValues.js 2.08% <0.00%> (-97.92%) :arrow_down:
...ic/src/js/components/Dropzone/ShapefileDropzone.js 12.50% <0.00%> (-87.50%) :arrow_down:
...rc/js/components/FormFields/RadioList/RadioList.js 8.69% <0.00%> (-87.14%) :arrow_down:
...s/components/CollectionDetails/RelatedUrlsModal.js 5.00% <0.00%> (-81.37%) :arrow_down:
static/src/js/components/Facets/FacetsList.js 10.34% <0.00%> (-75.87%) :arrow_down:
static/src/js/components/Map/ShapefileLayer.js 13.19% <0.00%> (-75.13%) :arrow_down:
static/src/js/components/Facets/FacetsItem.js 7.40% <0.00%> (-68.46%) :arrow_down:
static/src/js/components/Map/GranuleGridLayer.js 12.50% <0.00%> (-68.18%) :arrow_down:
... and 179 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 19 '22 12:09 codecov[bot]

There is one more test failing, but it looks like a real issue. After downloading your branch and trying it out, clicking on the "Available in Earthdata Cloud" facet does not apply the facet to the query, and does not load new collections

macrouch avatar Sep 20 '22 16:09 macrouch

Thank you for the help and being patient with me @macrouch. This is the first time contributing to such a big project. Will try to resolve this issue.

Vinitvh avatar Sep 20 '22 17:09 Vinitvh

Closing due to inactivity

macrouch avatar Feb 02 '23 16:02 macrouch