cFS icon indicating copy to clipboard operation
cFS copied to clipboard

Fix #595, Remove obsolete lgtm config file

Open skliper opened this issue 3 years ago • 4 comments

Checklist (Please check before submitting)

Describe the contribution

  • Fix #595

Testing performed CI

Expected behavior changes None

System(s) tested on CI

Additional context None

Code contributions The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.

Contributor Info - All information REQUIRED for consideration of pull request Jacob Hageman - NASA/GSFC

skliper avatar Oct 14 '22 19:10 skliper

Heads up @dmknutsen @dzbaker, looks like there's some real failures that started recently in CI: https://github.com/nasa/cFS/actions/runs/3230286177 (also causing the issue w/ this one). There's also quite a few (8 of the workflows) deprecation warnings popping up in CI: https://github.com/nasa/cFS/pull/590/checks. Some are just Ubuntu, but it looks like there's others.

skliper avatar Oct 14 '22 19:10 skliper

Heads up @dmknutsen @dzbaker, looks like there's some real failures that started recently in CI: https://github.com/nasa/cFS/actions/runs/3230286177 (also causing the issue w/ this one). There's also quite a few (8 of the workflows) deprecation warnings popping up in CI: https://github.com/nasa/cFS/pull/590/checks. Some are just Ubuntu, but it looks like there's others.

@skliper Thanks for the heads up! I believe these PRs should resolve at least some of the failures: https://github.com/nasa/cFS/pull/589 and https://github.com/nasa/cFE/pull/2165. I should be merging the PRs fairly soon (I'm just waiting on a couple of fixes to other PRs going into the bundle).

dzbaker avatar Oct 14 '22 19:10 dzbaker

Looks like the org owners have to uninstall the lgtm.com app from the repos to actually remove the analysis and related warnings. I'll put in a request.

skliper avatar Oct 14 '22 19:10 skliper

Looks like the org owners have to uninstall the lgtm.com app from the repos to actually remove the analysis and related warnings. I'll put in a request.

Ok, thanks!

dzbaker avatar Oct 14 '22 19:10 dzbaker