cFE icon indicating copy to clipboard operation
cFE copied to clipboard

Fix #2556, flight like platformed defined values

Open dmknutsen opened this issue 1 year ago • 3 comments

Checklist (Please check before submitting)

Describe the contribution Updates CFE_PLATFORM_EVS_LOG_MAX and CFE_PLATFORM_EVS_APP_EVENTS_PER_SEC to align with 'flight like' values

  • Fixes #2556

Testing performed CI pipeline BVT testing

System(s) tested on

  • Ubuntu 20.04
  • cFE Development Build equuleus-rc1+dev131 (Codename Equuleus), Last Official Release: cFE v6.7.0)

Contributor Info - All information REQUIRED for consideration of pull request Dan Knutsen NASA Goddard

dmknutsen avatar May 09 '24 15:05 dmknutsen

Might be a surprise to anyone using the defaults? Is there a way to match the BVTs w/o open source behavior changes?

skliper avatar May 09 '24 16:05 skliper

Yep - we could just put the updates in the example_platform_cfg.h (and change the name as part of the test setup). I'm a bit surprised that the functional tests failed, as I just changed CFE_PLATFORM_EVS_APP_EVENTS_PER_SEC back to it's original value that I was thinking was more flight like. The only reason we changed it in the first place was to prevent test results from being squelched in the console output (cfe_test.log has always been correct). In any case, just using example_platform_cfg.h fixes both issues...I'll push an update.

dmknutsen avatar May 09 '24 17:05 dmknutsen

@dmknutsen Would you be able to go over this one at next week's CCB?

dzbaker avatar Sep 12 '24 18:09 dzbaker