cFE
cFE copied to clipboard
Fix #1497, Use CFE_TIME_SysTime_t instead of indiv. sec/subsec members
Checklist
- [x] I reviewed the Contributing Guide.
- [x] I signed and emailed the appropriate Contributor License Agreement to [email protected] and copied [email protected].
Describe the contribution
- Fixes #1497
- Remaining individual (
uint32
) members representing seconds/sub-seconds for file creation time were converted to use the unifiedCFE_TIME_SysTime_t
type in 7 locations.
- Remaining individual (
Testing performed
All tests were passing before changes to CFE_FS_Header_t
were added (see https://github.com/nasa/cFE/actions/runs/4585928750 and https://github.com/nasa/cFE/actions/runs/4585928751).
The functional test and CodeQL analyses are no longer able to build because elf2cfetbl references the old uint32
members in CFE_FS_Header_t
directly, so an additional PR for elf2cfetbl is required at the same time - see https://github.com/nasa/elf2cfetbl/pull/134.
Local tests with full cFS package confirm all tests passing when both changes are made together, and net coverage unaffected.
Note: If this is merged it will require updates to some of the txt files in the Ground System tool to ensure clean and correct interpretation of the data members.
System(s) tested on Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64 Debian GNU/Linux 11 (bullseye) Current main branch of cFS.
Expected behavior changes No change to behavior.
Contributor Info Avi Weiss @thnkslprpt
You have successfully added a new CodeQL configuration coding-standard
. As part of the setup process, we have scanned this repository and found 1905 existing alerts. Please check the repository Security tab to see all alerts.
You have successfully added a new CodeQL configuration security
. As part of the setup process, we have scanned this repository and found 29 existing alerts. Please check the repository Security tab to see all alerts.
Partially implemented in https://github.com/nasa/cFE/pull/2544