Replace magic number in `CFE_EVS_MAX_PORT_MSG_LENGTH` defnition

Open skliper opened this issue 4 years ago • 3 comments

Is your feature request related to a problem? Please describe. Magic number used: https://github.com/nasa/cFE/blob/73c338d544f85cb0c1a97b743d3ae9f7a35039b5/modules/evs/fsw/src/cfe_evs_task.h#L63

Describe the solution you'd like Use a defined size (this is probably for time)

Describe alternatives you've considered None

Additional context Code review

Requester Info Jacob Hageman - NASA/GSFC

Apr 28 '21 17:04 skliper

@skliper Can the magic number (30) just be replaced with CFE_TIME_PRINTED_STRING_SIZE?

Jan 16 '24 01:01 thnkslprpt

My guess is it's probably a little bigger than that due to the other information in the printed event. Example:

EVS Port1 1980-012-14:03:20.65013 66/1/SC 9: SC Initialized. Version 3.1.99.0

It doesn't look like these parts would be accounted for: EVS port1 66/1 9:

Jan 16 '24 15:01 skliper

Note: see https://github.com/nasa/cFE/pull/2566 and https://github.com/nasa/cFE/issues/2571

Jul 14 '24 07:07 thnkslprpt