astrobee icon indicating copy to clipboard operation
astrobee copied to clipboard

Merge bag tools into one

Open marinagmoreira opened this issue 3 years ago • 6 comments

There is currently 2 merge bag tools in astrobee/tools/graph_bag/scripts/merge_bags.py and astrobee/localization/localization_node/tools/merge_bags.cc.

The functionality of both should be merged into the c++ api one (because the python api crashes with messages from rosjava) and moved to the astrobee/tools folder for better visibility of users

marinagmoreira avatar Nov 09 '21 00:11 marinagmoreira

@rsoussan this isn't super urgent, but do you use tools/graph_bag/scripts/merge_bags.py? What does this have that astrobee/localization/localization_node/tools/merge_bags.cc lacks?

bcoltin avatar Jan 20 '22 21:01 bcoltin

It automatically finds bags with a given prefix in a directory and merges them, and adds an option to only save localization topics to keep the bags smaller.

rsoussan avatar Jan 21 '22 01:01 rsoussan

We'll move all the bag processing scripts from both locations into a new ros package in tools.

bcoltin avatar Feb 28 '22 23:02 bcoltin

We think the python script does everything and we can now delete the C++ script. However, let's wait a bit to make sure we still don't need it.

bcoltin avatar Aug 22 '22 22:08 bcoltin

@marinagmoreira will add a warning to the C++ version that it is obsolete.

bcoltin avatar Aug 22 '22 22:08 bcoltin

Also merged both python merge scripts into one, that can merge entire directory or selected files

marinagmoreira avatar Oct 04 '22 20:10 marinagmoreira

Will call the C++ script from python and get rid of the duplicate functionality in the python script.

bcoltin avatar Nov 08 '22 00:11 bcoltin