💡 [Magic Number Removal] - CBC Padding parameters in AOS and TM

Open dccutrig opened this issue 9 months ago • 1 comments

Summary

Look at and review the correct bounds for CBC Padding parameters in AOS and TM, then set thsese as #defines instead of magic numbers (e.g. 16)

Don't blanket use 16 - we need to understand the actual limitations in conjunction with the telemetry frames. (e.g. what happens if we aren't using idle frames... does CBC auto-pad out the whole frame?)

Use Case

Will be needed in future for telemetry support

Mar 17 '25 16:03 dccutrig

Examine: if (*len_ingest < tc_sdls_processed_frame->tc_header.fl + 1) // Specified frame length larger than provided frame!

as well in crypto_tc.c - are we able to make it a != to tighten it up, or does this negatively affect CBC processing?

Mar 18 '25 14:03 dccutrig