CryptoLib icon indicating copy to clipboard operation
CryptoLib copied to clipboard

Examine TLV bounding

Open dccutrig opened this issue 1 year ago • 2 comments

Examine TLV bounding in Crypto_Process_Extended_Procedure_Pdu.

Need to ensure that TLV values in a packet are:

  1. Less than or equal to Max TLV Length (done, and fixed otherwise segfault - UTs exist) , and
  2. That TLV values make sense in the context of the length of both frames and space packets received

2 is a little more complicated and I can revisit

dccutrig avatar Dec 17 '24 22:12 dccutrig

Behold, an example of what mismatched lengths and corrupted values can currently do - and also the point of this issue:

image

dccutrig avatar Dec 18 '24 18:12 dccutrig

Need to look deeper into sa_start

Donnie-Ice avatar Feb 11 '25 00:02 Donnie-Ice