CS icon indicating copy to clipboard operation
CS copied to clipboard

Fix #26, Use `CFE_ES_MemAddress_t` instead of `cpuaddr` in tables/tlm/cmd structs

Open thnkslprpt opened this issue 1 year ago • 0 comments

Checklist

Describe the contribution

  • Fixes #26
    • Convert cpuaddr types in tables/cmd/tlm structs to fixed-size CFE_ES_MemAddress_t
      • removed the Filler32 in CS_Res_EepromMemory_Table_Entry_t (I assume it was there to align to the 64-bit cpuaddr which is is longer necessary (unless/until CFE_ES_MemAddress_t and CFE_ES_MemOffset_t are redefined as 64-bits in https://github.com/nasa/cFE/issues/2093. Another option is to just leave it in now for future compatibility with 64-bit alignment.

Testing performed GitHub CI actions all passing successfully (incl. Build + Run, Unit/Coverage Tests etc.).

Expected behavior changes Exposed structs will no longer change size based on the definition of cpuaddr.

Contributor Info Avi Weiss @thnkslprpt

thnkslprpt avatar Jun 11 '23 23:06 thnkslprpt