CS icon indicating copy to clipboard operation
CS copied to clipboard

Fix #52, Apply consistent Event ID names to common events

Open thnkslprpt opened this issue 2 years ago • 2 comments

Checklist

Describe the contribution

  • Fixes #52
    • Consistent event IDs have been applied to the inconsistent cases to align them with a common Event ID naming convention.

Testing performed Only GitHub CI actions.

Expected behavior changes No impact on code behavior (no logic changes). Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.

Contributor Info Avi Weiss @thnkslprpt

thnkslprpt avatar Oct 21 '22 06:10 thnkslprpt

Looks good!

Cheers mate.

thnkslprpt avatar Nov 01 '22 03:11 thnkslprpt

CCB:2023.03.09: Putting on hold until naming conventions for event, etc are merged.

chillfig avatar Mar 09 '23 19:03 chillfig

It looks like in the recent rebase, some updates got merged incorrectly, causing the workflow failure

jphickey avatar Jul 11 '24 13:07 jphickey

Rebased to latest mainline and manually fixed up some merge overlaps re: payload member. Workflows now pass and this should be good to go.

jphickey avatar Jul 11 '24 14:07 jphickey

Thanks Joe.

thnkslprpt avatar Jul 11 '24 18:07 thnkslprpt