nasa
Fix #441, cf delete files during error when tx
Fix #441, Update to handle an error during tx. For polling, the file gets moved or deleted to prevent an infinite loop. For others, the file does not get deleted. Update Unit Test.
Checklist (Please check before submitting)
- [x] I reviewed the Contributing Guide.
- [x] I signed and emailed the appropriate Contributor License Agreement to [email protected] and copied [email protected].
Describe the contribution A clear and concise description of what the contribution is.
- Include explicitly what issue it addresses [e.g. Fixes #X] Fix #441, cf delete file during error when tx.
Testing performed Steps taken to test the contribution:
-
Tx class 2 cmd and make fail. ( ack limit reached, no eof-ack)
-
Check file has not been deleted.
-
Put in polling directory and see and make fail (ack limit reached, no eof-ack)
-
Check file has been moved to fail directory
-
File is no longer in polling directory
-
Put in polling directory, no failing directory, and make fail ( ack limit reached, no eof-ack)
-
The file is deleted from the polling directory.
Expected behavior changes A clear and concise description of how this contribution will change behavior and level of impact.
- When an error occurs during the TX. a. if the file is not in a polling directory, do nothing b. if the file is in a polling directory, attempt to move to the "fail" directory and delete it from the polling directory.
System(s) tested on
- Hardware: [e.g. PC, SP0, MCP750]
- OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
- Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools] Tested on a docker container with ubuntu22.04 running against COSMOS
Additional context Add any other context about the contribution here.
Third party code If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request Full name and company/organization/center of all contributors ("Personal" if individual work)
- Note CLA's apply to software contributions. Anh Van, GSFC
