CF icon indicating copy to clipboard operation
CF copied to clipboard

fix #445, update to meet standard

Open avan989 opened this issue 1 year ago • 1 comments

fix #445,

  1. update CF_DoSuspRes to increment the command counter and issue an info event instead of an error event.
  2. Update the Enable_engine command to increment the cmd counter when the state stays the same and issue info event.
  3. Update Disable engine command to increment cmd counter when stat stays the same and issue info event.

Checklist (Please check before submitting)

Describe the contribution A clear and concise description of what the contribution is. Fixes #445, Update Suspend/Resume/Enable_engine/Disable_engine to conform to standard

Testing performed Steps taken to test the contribution:

  1. Build

  2. Send Command

  3. See info event and verify cmd counter increment

  4. Build For unit test

  5. Verify all cases pass and lcov is still 100%

Expected behavior changes A clear and concise description of how this contribution will change behavior and level of impact.

  • API Change: xxx (if applicable)
  • Behavior Change: xxx (if applicable)
  • Or no impact to behavior

System(s) tested on

  • Hardware: [e.g. PC, SP0, MCP750]
  • OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context Add any other context about the contribution here.

Third party code If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request Full name and company/organization/center of all contributors ("Personal" if individual work)

  • Note CLA's apply to software contributions. Anh Van, GSFC

avan989 avatar May 31 '24 13:05 avan989

CCB 27 June 2024: Will review at CCB once Event ID Naming PRs have been merged.

dzbaker avatar Jun 27 '24 18:06 dzbaker