CF icon indicating copy to clipboard operation
CF copied to clipboard

CF_UnionArgs_Payload_t elements dword and hword not used, union not necessary

Open skliper opened this issue 2 years ago • 1 comments

Checklist (Please check before submitting)

  • [x] I reviewed the Contributing Guide.
  • [x] I reviewed the CF README.md file to see if the feature is in the major future work.
  • [x] I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe. dword and hword are not used in the CF_UnionArgs_Payload_t union, only byte: https://github.com/nasa/CF/blob/07747463131050606cc58127b932a4c580d4a57f/fsw/src/cf_msg.h#L159-L169

Describe the solution you'd like Remove unnecessary union

Describe alternatives you've considered CF_UnionArgsCmd_t is somewhat out of family in that it specifies unnecessary payload elements for some of the commands. The only common benefit seems to be byte 0 which is channel, supporting all channels generically with 255. Consider untangling all the layers of abstraction and go back to simple command processing.

Additional context None

Requester Info Jacob Hageman - NASA/GSFC

skliper avatar Jul 21 '22 22:07 skliper

Initial PR solving this issue is reverted by https://github.com/nasa/CF/pull/395. Reopening to be considered for Equuleus-rc2.

chillfig avatar Jul 11 '23 18:07 chillfig