worldview icon indicating copy to clipboard operation
worldview copied to clipboard

WV-2448: Change default Corrected Reflectance layer & initial map position

Open Tomcariello opened this issue 2 years ago • 4 comments

Description

Terra will be adjusting its orbital configuration on October 12, 2022 at which point it will not produce data. We need to alter the following in WV:

  • Change the default Corrected Reflectance layer from Terra/MODIS to Aqua/MODIS.
  • Adjust the default map position to be more eastward to compensate for Aqua/MODIS later overpass time compared to Terra.

How To Test

  • Load the PR.
  • Run npm run build:config to update the configuration.
  • Load WV & confirm:
    • The default layers are loading properly.
    • The default time is loading properly.

@nasa-gibs/worldview

Tomcariello avatar Sep 22 '22 20:09 Tomcariello

Some things to consider, probably for @minniewong to answer:

  • Do we change the defaults for event layers?
  • Do we change the defaults for tour story layers?

jasontk19 avatar Sep 23 '22 15:09 jasontk19

Some things to consider, probably for @minniewong to answer:

  • Do we change the defaults for event layers?
  • Do we change the defaults for tour story layers?

Sigh. We probably should change the default layer for events that use Terra CR; for Tour stories, luckily we'd only have to change the default layer for the Intro to Worldview story.

minniewong avatar Sep 23 '22 15:09 minniewong

@minniewong It looks like most of the tour stories have MODIS_Terra_CorrectedReflectance_TrueColor in their permalinks. Sometimes it's hidden but sometimes not. Is it because they usually only point to dates in the past that we don't need to update these?

jasontk19 avatar Sep 23 '22 16:09 jasontk19

@minniewong It looks like most of the tour stories have MODIS_Terra_CorrectedReflectance_TrueColor in their permalinks. Sometimes it's hidden but sometimes not. Is it because they usually only point to dates in the past that we don't need to update these?

Yep - the outage will start 12 October 2022 and last over 10 days, past dates will still show imagery, so it's fine.

minniewong avatar Sep 23 '22 16:09 minniewong

@minniewong How far east should the default be shifted? What's here now looks good to me but also, at this time of day a lot more imagery coverage is available. I think this is fine but I defer to you on the positioning.

jasontk19 avatar Sep 26 '22 21:09 jasontk19

So, there are two test cases for the existing behavior which represent a current time of 0000Z and 0300Z.

For the first test case of 0000Z, the map seems kind of far west and a lot of blank area is visible: http://localhost:3000/?now=2022-09-27T00%3A00%3A00Z

And for the second test case of 0300Z, the map is so far east that it crosses the dateline: http://localhost:3000/?now=2022-09-27T03%3A00%3A00Z

I think the first is probably too far west and the second is too far east.

jasontk19 avatar Sep 27 '22 14:09 jasontk19

For reference here are the same links in prod:

0000Z

0300Z

jasontk19 avatar Sep 27 '22 14:09 jasontk19

I have adjusted the values to better align with the needs of the Aqua/MODIS Corrected Reflectance layer. I have discarded the old values, which were tuned for the Terra/MODIS Corrected Reflectance layer.

The comments at lines 113-119, describing an intention to adjust based on the time of day, are no longer applicable/accurate. The goal of this function is to return values that result in a map with current imagery & a minimal amount of missing/upcoming imagery. There is no longer any manipulation of the map location based on the time of day.

Tomcariello avatar Sep 27 '22 16:09 Tomcariello

I think this looks ok now but, I am not sure if we do want to keep the behavior that shifts the map westward when loading at 0000Z. Will defer to @minniewong

jasontk19 avatar Sep 27 '22 16:09 jasontk19

I think this looks ok now but, I am not sure if we do want to keep the behavior that shifts the map westward when loading at 0000Z. Will defer to @minniewong

We'd only want the shifting behaviour during the time that Terra is not working (10+ days after 10 October). When Terra comes back, we'd want to return to how it used to work.

minniewong avatar Sep 27 '22 18:09 minniewong

There was time based behavior applied to Terra (at 00:00 UTC, start at far eastern edge of map; at 23:00 UTC, start at far western edge of map) which is not being applied to the Aqua CR layer. The only shifting applied to the Aqua layer is moving the map to the east to ensure that the map imagery is populated.

Once we switch back to Terra all of this code will be reverted & the time based adjustments will be re-applied & the eastward shift removed.

Tomcariello avatar Sep 28 '22 13:09 Tomcariello