mrf icon indicating copy to clipboard operation
mrf copied to clipboard

What is the difference between mrf_read.py and mrf_read_data.py?

Open lucianpls opened this issue 3 years ago • 9 comments

lucianpls avatar Jul 22 '21 19:07 lucianpls

Seems like the usage between the two is the major difference:

mrf_read_data.py --input [mrf_data_file] --output [output_file] (--offset INT --size INT) OR (--index [index_file] --tile INT)
mrf_read.py --input [mrf_file] --output [output_file] (--tilematrix INT --tilecol INT --tilerow INT) OR (--offset INT --size INT) OR (--tile INT)

mcechini avatar Jul 23 '21 13:07 mcechini

Doesn't sound like there is enough to keep both. Are you using any of these? The mrf_read_index is another one, you can do the same thing with "od".

lucianpls avatar Jul 23 '21 17:07 lucianpls

I am using mrf_read.py

mike-mcgann avatar Jul 23 '21 17:07 mike-mcgann

What for? QC?

lucianpls avatar Jul 23 '21 17:07 lucianpls

Yes, it is used in our automated end-to-end tests

mike-mcgann avatar Jul 23 '21 17:07 mike-mcgann

We could consider consolidating if needed, but I find mrf_read.py's (--tilematrix INT --tilecol INT --tilerow INT) options to be very helpful.

mcechini avatar Jul 23 '21 18:07 mcechini

I don't see any strong reason to keep mrf_read_data.py

jtroberts avatar Jul 24 '21 00:07 jtroberts

That would be good. Maybe the mrf_read_index could be eliminated too, since it's not that useful? Or have it merged into mrf_read.py.

lucianpls avatar Jul 27 '21 18:07 lucianpls

I like the CSV output of mrf_read_index, but rarely every use it. I think it is helpful for debugging and understanding MRFs. It would be nice to merge it into mrf_read and then have only one tool to maintain.

jtroberts avatar Jul 28 '21 02:07 jtroberts