test: codspeed CI workflow
What type of PR is this? (check all applicable)
- [ ] πΎ Refactor
- [ ] β¨ Feature
- [ ] π Bug Fix
- [ ] π§ Optimization
- [ ] π Documentation
- [x] β Test
- [ ] π³ Other
Related issues
- Related issue #805
Checklist
- [x] Code follows style guide (ruff)
- [x] Tests added
- [x] Documented the changes
If you have comments or can explain your changes, please do so below.
- I am opening this with 3 queries only for the sake of example
- I wonder if the data size we are using is relevant
Maybe you did it, but just in case: Don't forget to add Narwhals to CodSpeed (you need admin rights). Even if you were able to previously test your fork.
Maybe you did it, but just in case: Don't forget to add Narwhals to CodSpeed (you need admin rights). Even if you were able to previously test your fork.
Maybe I am missing something, but checking in repo settings, I am able to see it enabled. Adding screenshots:
And then in configure:
From the error message it seems we still need a token?
I don't have access to: repo settings
OK. I didn't need a token. Plus it says that the repo has not been enabled. What do you see on Narwhals permissions on Codspeed? BTW Codspeed only accepts organizations.
edit: Please see https://docs.codspeed.io/features/roles-and-permissions/ if this is unclear.
Your name must be listed as admin or provider admin on "permissions". But not of your fork, the Narwhals organization:
I stop now, I promise.
I should have enabled it, I will make a commit to trigger all the workflows one more time :)
Edit: Nice it works now ππΌπ
CodSpeed Performance Report
Congrats! CodSpeed is installed π
π 4 new benchmarks were detected.
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
Detected benchmarks
test_queries[dask](295.1 ms)test_queries[pandas](13.9 ms)test_queries[polars](3.2 ms)test_queries[pyarrow](3.7 ms)
@MarcoGorelli I will wait for an opinion before going rogue and implement all the queries π
sure, looks good to me, thanks!
Should this be closed?
Hey @DeaMariaLeon thanks for the ping!
Sure I will close this as it is out of sync and wait for #863 to be finished before putting more effort into it