narwhals icon indicating copy to clipboard operation
narwhals copied to clipboard

test: codspeed CI workflow

Open FBruzzesi opened this issue 1 year ago β€’ 8 comments

What type of PR is this? (check all applicable)

  • [ ] πŸ’Ύ Refactor
  • [ ] ✨ Feature
  • [ ] πŸ› Bug Fix
  • [ ] πŸ”§ Optimization
  • [ ] πŸ“ Documentation
  • [x] βœ… Test
  • [ ] 🐳 Other

Related issues

  • Related issue #805

Checklist

  • [x] Code follows style guide (ruff)
  • [x] Tests added
  • [x] Documented the changes

If you have comments or can explain your changes, please do so below.

  • I am opening this with 3 queries only for the sake of example
  • I wonder if the data size we are using is relevant

FBruzzesi avatar Aug 19 '24 20:08 FBruzzesi

Maybe you did it, but just in case: Don't forget to add Narwhals to CodSpeed (you need admin rights). Even if you were able to previously test your fork.

DeaMariaLeon avatar Aug 20 '24 06:08 DeaMariaLeon

Maybe you did it, but just in case: Don't forget to add Narwhals to CodSpeed (you need admin rights). Even if you were able to previously test your fork.

Maybe I am missing something, but checking in repo settings, I am able to see it enabled. Adding screenshots:

image

And then in configure:

image

From the error message it seems we still need a token?

FBruzzesi avatar Aug 20 '24 06:08 FBruzzesi

I don't have access to: repo settings

OK. I didn't need a token. Plus it says that the repo has not been enabled. What do you see on Narwhals permissions on Codspeed? BTW Codspeed only accepts organizations.

edit: Please see https://docs.codspeed.io/features/roles-and-permissions/ if this is unclear.

DeaMariaLeon avatar Aug 20 '24 07:08 DeaMariaLeon

Your name must be listed as admin or provider admin on "permissions". But not of your fork, the Narwhals organization:

Screenshot 2024-08-20 at 09 35 56

I stop now, I promise.

DeaMariaLeon avatar Aug 20 '24 07:08 DeaMariaLeon

I should have enabled it, I will make a commit to trigger all the workflows one more time :)

Edit: Nice it works now πŸ™ŒπŸΌπŸŽ‰

FBruzzesi avatar Aug 20 '24 11:08 FBruzzesi

CodSpeed Performance Report

Congrats! CodSpeed is installed πŸŽ‰

πŸ†• 4 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • test_queries[dask] (295.1 ms)
  • test_queries[pandas] (13.9 ms)
  • test_queries[polars] (3.2 ms)
  • test_queries[pyarrow] (3.7 ms)

codspeed-hq[bot] avatar Aug 20 '24 13:08 codspeed-hq[bot]

@MarcoGorelli I will wait for an opinion before going rogue and implement all the queries πŸ˜‚

FBruzzesi avatar Aug 20 '24 13:08 FBruzzesi

sure, looks good to me, thanks!

MarcoGorelli avatar Aug 20 '24 13:08 MarcoGorelli

Should this be closed?

DeaMariaLeon avatar Sep 05 '24 12:09 DeaMariaLeon

Hey @DeaMariaLeon thanks for the ping!

Sure I will close this as it is out of sync and wait for #863 to be finished before putting more effort into it

FBruzzesi avatar Sep 05 '24 14:09 FBruzzesi