narwhals icon indicating copy to clipboard operation
narwhals copied to clipboard

[Enh]: Extend signature of supported methods

Open FBruzzesi opened this issue 1 year ago • 1 comments

We would like to learn about your use case. For example, if this feature is needed to adopt Narwhals in an open source project, could you please enter the link to it below?

No response

Please describe the purpose of the new feature or describe the problem to solve.

There are some methods for which we have partial support, meaning that not the full polars api is supported.

However this should be possible for some methods and/or some arguments (examples below)

Suggest a solution if possible.

No response

If you have tried alternatives, please describe them below.

No response

Additional information that may help us understand your needs.

Here a (partial) list of methods and arguments missing:

method missing argument(s) note
DataFrame.drop strict ✅ Fixed in #773
DataFrame.drop_nulls subset ✅ Fixed in #779
DataFrame.get_column default It possibly depends on #754
DataFrame.join suffix
DataFrame.join_asof suffix, tolerance

FBruzzesi avatar Aug 08 '24 08:08 FBruzzesi

cool, happy to expand where it makes sense - if it's possible to get support across pandas/polars/pyarrow then it's probably already worth doing!

MarcoGorelli avatar Aug 13 '24 16:08 MarcoGorelli

Closing this for now, we can come back to join_asof and other methods when and if required for adoption

FBruzzesi avatar Oct 19 '24 10:10 FBruzzesi