narwhals icon indicating copy to clipboard operation
narwhals copied to clipboard

feat: add support for `replace_strict` for SparkLike

Open lucas-nelson-uiuc opened this issue 9 months ago • 1 comments

Hey everyone,

Noticed that replace_strict is not listed in the not-implemented section of the expr script:

https://github.com/narwhals-dev/narwhals/blob/a2796344571f8efe68306ef4cb263ad11980e0ff/narwhals/_spark_like/expr.py#L621-L631

I know we talked about holding off in #1724 - just wanted to check on how we're feeling about that now?

Happy to put together a basic version that doesn't implement any window/collect expressions. Lmk!

lucas-nelson-uiuc avatar Mar 19 '25 22:03 lucas-nelson-uiuc

Hey @lucas-nelson-uiuc, thanks for the issue! Yes this is definitly something we want to support 👌

FBruzzesi avatar Mar 19 '25 22:03 FBruzzesi