narwhals icon indicating copy to clipboard operation
narwhals copied to clipboard

[Doc]: use uv pip in Installation and Quick Start (just as in Contributing.md)

Open anopsy opened this issue 1 year ago • 3 comments

What type of report is this?

Correction

Please describe the issue.

Installation and Quick Start uses just pip while CONTRIBUTING.md advices to use uv pip Shall we make it consistent? Or is there a reason to prefer python -m pip install narwhals in the Installation and Quick Start? https://narwhals-dev.github.io/narwhals/installation/

If you have a suggestion on how it should be, add it below.

No response

anopsy avatar Sep 24 '24 11:09 anopsy

thanks for raising this!

in the contributing guide, i think it's ok to be more opinionated

in the user guide, on the other hand, i think we should be less opinionated, and more like "whatever tool you use to manage your dependencies, here's how you can install narwhals into it"

MarcoGorelli avatar Sep 24 '24 21:09 MarcoGorelli

Sounds fair! Then I'll close this one

anopsy avatar Sep 25 '24 06:09 anopsy

ah wait sorry I wasn't clear 😄 I think we should include UV as well in the quick start, but perhaps be less opinionated about it (e.g. perhaps there we shouldn't write "recommended")

reopening then if it's ok

MarcoGorelli avatar Sep 25 '24 08:09 MarcoGorelli