narwhals icon indicating copy to clipboard operation
narwhals copied to clipboard

chore: type `constructor_eager` as `ConstructorEager` instead of `Constructor`

Open MarcoGorelli opened this issue 1 year ago • 1 comments

In here

https://github.com/narwhals-dev/narwhals/blob/9353ef9f681f032feee777fabbb8db8ae98aa79d/tests/utils.py#L20

we have Constructor

The task is here it to:

  • make ConstructorEager, with IntoDataFrame instead of IntoFrame
  • in tests that have constructor_eager: Any, use instead constructor_eager: ConstructorEager. You may need to import it, see other tests for examples

MarcoGorelli avatar Sep 20 '24 12:09 MarcoGorelli

I'll take this one if no one is on it 😊

lucianosrp avatar Sep 26 '24 14:09 lucianosrp