Vladimir Varankin
Vladimir Varankin
**Update** I've found https://github.com/zed-industries/zed/issues/11894 that covers my use-case. --- > Can you file an issue for the specific case you’re working with? More problem oriented than solutions oriented, though feel...
Looking through the first round of comments, I thought maybe it will help if I try to outline the general mechanics of processing in a pseudocode. The `nextConsumeCycle` retrieves the...
I think, I addressed most of structural comments, PHAL. Meanwhile, I'll prepare a follow-up PR with more tests.
I think, I've addressed everything here. Should be good for another review round
I've addressed all the latest comments. PTAL
The fix looks good to me. But I think there is one place in the changeset, that also needs fixing (refer to the in place comment). Also, could you add...
> in `values.yaml` mimir config endpoint sould use `{{ .Values.minio.service.port }}` instead of 9000? That's a great point, thank you. Fixing it should be a noop for the chart and...
The CHANGELOG has just been cut to prepare for the next release. Please rebase `main` and eventually move the CHANGELOG entry added / updated in this PR to the top...
> Various sources online claim performance benefits in the order of 2-14%. This is a significant performance improvement at a relatively low cost. Last time I asked internally, when people...
Wasn't that what #7421 fix already?