dummygram icon indicating copy to clipboard operation
dummygram copied to clipboard

Improved the aesthetics of this project #1317

Open devArghya-0155 opened this issue 1 year ago • 7 comments

Changes made are listed below:

  1. Changed the background colour of body, sidebar, navbar and suggestions. It works correctly in both light mode and dark mode.

  2. Improved post structure -

    • Changed the position of post caption. It is now above the post.
    • Fixed the colour of post caption. It had a grey background in dark mode.
    • Changed the structure of post nav. Post stats (number of likes and comments) and the option to like, comment, share & bookmark occupy the same place.
    • Added interactive screentips to each button.
    • Changed the background of comment box to separate it from other post content. Works correctly in both dark and light mode.
  3. Made some minor changes to few other components.

image

image

Please let me know if there are any errors. I will fix them at the earliest.

devArghya-0155 avatar Jan 01 '24 10:01 devArghya-0155

Quality Gate Failed Quality Gate failed

Failed conditions

B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

sonarqubecloud[bot] avatar Jan 01 '24 10:01 sonarqubecloud[bot]

hi @devArghya-0155 I'm traveling right now and will be free in a day, I'll review this pr then.Thanks for your patience

narayan954 avatar Jan 02 '24 11:01 narayan954

hi @devArghya-0155 I'm traveling right now and will be free in a day, I'll review this pr then.Thanks for your patience

Please review my pr and let me know what changes need to be made.

devArghya-0155 avatar Jan 05 '24 16:01 devArghya-0155

hi @devArghya-0155 I'm traveling right now and will be free in a day, I'll review this pr then.Thanks for your patience

Please review my pr and let me know what changes need to be made.

Yes, really sorry for the delay, actually it's having merge conflicts which can only be solved on a desktop, that's why the delay

narayan954 avatar Jan 06 '24 17:01 narayan954

Quality Gate Failed Quality Gate failed

Failed conditions

B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

also, can you please check the code analysis review, it's smelling something

narayan954 avatar Jan 06 '24 17:01 narayan954

hi @devArghya-0155 can you please check if it's responsive... it's breaking in every screen

references: image image image

narayan954 avatar Jan 06 '24 19:01 narayan954

hi @devArghya-0155 can you please check if it's responsive... it's breaking in every screen

references: image image image

I am working on these issues now.

devArghya-0155 avatar Jan 07 '24 06:01 devArghya-0155

closed due to inactivity

narayan954 avatar Jun 17 '24 10:06 narayan954