nap
nap copied to clipboard
CMake Error at tools/napkin/CMakeLists.txt:218 (if):
trafficstars
if given arguments:
"STREQUAL" "Release"
Unknown arguments specified
This is with cmake 3.29
Fix:
diff --git a/tools/napkin/CMakeLists.txt b/tools/napkin/CMakeLists.txt
index fabca61ea..de0f76505 100644
--- a/tools/napkin/CMakeLists.txt
+++ b/tools/napkin/CMakeLists.txt
@@ -215,7 +215,7 @@ if(APPLE)
elseif(UNIX)
- if (${CMAKE_BUILD_TYPE} STREQUAL "Release")
+ if ("${CMAKE_BUILD_TYPE}" STREQUAL "Release")
list(APPEND DEEP_DEPENDENT_RPATHS ${PATH_TO_THIRDPARTY}/Qt/lib)
list(APPEND DEEP_DEPENDENT_RPATHS lib)
Could you submit this as a PR instead of logging it as a bug? NAP ships with it's own version of CMAKE (cmake version 3.21.3) in thirdparty and that's the one we support. Your change is compiled and validated, ensuring the change doesn't break existing builds.
Not an issue with current supported cmake