napari icon indicating copy to clipboard operation
napari copied to clipboard

Update script for vendored modules

Open Czaki opened this issue 1 year ago • 2 comments

Description

As current workflows for updating vendor modules produces warnings

obraz

This PR update workflow to use environment variables.

THere should be a decision on what should be done with matplotlib.

References

Type of change

  • [ ] Bug-fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How has this been tested?

  • [ ] example: the test suite for my feature covers cases x, y, and z
  • [ ] example: all tests pass with my change
  • [ ] example: I check if my changes works with both PySide and PyQt backends as there are small differences between the two Qt bindings.

Final checklist:

  • [ ] My PR is the minimum possible work for the desired functionality
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] If I included new strings, I have used trans. to make them localizable. For more information see our translations guide.

Czaki avatar Apr 26 '23 13:04 Czaki

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.73%. Comparing base (6a822eb) to head (62b63bd). Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5779      +/-   ##
==========================================
- Coverage   92.83%   92.73%   -0.10%     
==========================================
  Files         623      623              
  Lines       57099    57098       -1     
==========================================
- Hits        53005    52951      -54     
- Misses       4094     4147      +53     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 26 '23 13:04 codecov[bot]

IMO matplotlib should be left out, as it's not really strictly a copy-paste from a different package.

At the same time, maybe we should update it and see what breaks then fix it ?

Carreau avatar Jul 18 '23 16:07 Carreau

I think we should do as @Carreau suggested and update this module to whatever its current version is and see how things go...

brisvag avatar Sep 05 '24 15:09 brisvag

@brisvag updated

Czaki avatar Sep 06 '24 06:09 Czaki