napari.github.io icon indicating copy to clipboard operation
napari.github.io copied to clipboard

update point size variable names

Open alisterburt opened this issue 3 years ago • 6 comments

point size attribute names in the tutorial for the points layer were outdated - updated accordingly!

alisterburt avatar Jun 15 '21 18:06 alisterburt

thanks @goanpeca - I'm not sure what's going on with the tests, have you seen these errors before on this repo?

alisterburt avatar Jun 15 '21 20:06 alisterburt

I'm not sure what's going on with the tests, have you seen these errors before on this repo?

Hi @alisterburt can you add this step in your PR, to get that fix in ?

https://github.com/napari/napari.github.io/pull/134/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R46

goanpeca avatar Jun 15 '21 20:06 goanpeca

thanks for the suggestion - added and still failing but I see in #134 that the 'stable' tests fail there whilst the 'master' tests succeed so I think we're probably okay

alisterburt avatar Jun 15 '21 21:06 alisterburt

These errors happen if there are unclosed windows when the test quits. So if you can think of where a stray window might still be open and close it, it might fix it.

tlambert03 avatar Jun 15 '21 21:06 tlambert03

If this is still applicable, can we move these changes to napari/napari?

melissawm avatar Mar 04 '22 20:03 melissawm

I would have to check but I think so! AFK right now but will add to the list :)

alisterburt avatar Mar 04 '22 21:03 alisterburt

This change is already live in https://github.com/napari/docs image

psobolewskiPhD avatar Aug 30 '23 01:08 psobolewskiPhD