napalm
napalm copied to clipboard
napalm-automation
remove tox in favor of gh actions/act
Is this what you're proposing to use for local testing? https://github.com/nektos/act I'm not familiar with it yet, but not opposed. We'll need to update the docs for this change though.
With switch to GH actions, we ceased using Tox so we should just go ahead and remove it.
We can decide separately whether we want a local way to test GH actions behaviors.
With switch to GH actions, we ceased using Tox so we should just go ahead and remove it. We can decide separately whether we want a local way to test GH actions behaviors.
I think I disagree with that. I'm looking at it from a user / contributor perspective: having tox around doesn't hurt, while silently changing (or dropping) the current way of testing locally without offering a (documented) alternative does hurt. How would people test their proposed contributions before opening a PR?
Does Tox even work? At a minimum it is all out of date and doesn't actually correspond to our testing in GitHub actions.
For example, it is still testing Python 3.6 which will fail.
Is this what you're proposing to use for local testing? https://github.com/nektos/act I'm not familiar with it yet, but not opposed. We'll need to update the docs for this change though.
I think we can generally recommend pytest for local, single interpreter testing, and act for those who wish to execute the full GH actions suite prior to pushing.
Fair enough. Would you be willing to add some docs around this?
On Tue, 24 May 2022, 14:55 bewing, @.***> wrote:
Is this what you're proposing to use for local testing? https://github.com/nektos/act I'm not familiar with it yet, but not opposed. We'll need to update the docs for this change though.
I think we can generally recommend pytest for local, single interpreter testing, and act for those who wish to execute the full GH actions suite prior to pushing.
— Reply to this email directly, view it on GitHub https://github.com/napalm-automation/napalm/pull/1644#issuecomment-1135886592, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7L3F56DPWTWQKXLPRK3PTVLTGTNANCNFSM5WQW3XSQ . You are receiving this because you commented.Message ID: @.***>