kafka-python missing from requirements.txt

[grepory]

The official and locally built napalm-logs Docker container I made don't support the kafka transport. Upon inspection, I realized that kafka-python is missing from requirements.txt--so it will never make it into the container. I've fixed this in my fork, but wanted to know if that was deliberately left out or if there's a way to get it into the Docker container other than this that I'm not aware of.

[mirceaulinic]

Hey @grepory - sorry for late reply here. Kafka is one of the optional publishers, meaning that you need to manage the dependencies yourself. I had the feeling that this is already mentioned in the documentation, but it's not unfortunately: https://napalm-logs.com/en/latest/publisher/kafka.html :disappointed: So this should be corrected. That said, we can add a small feature so when installing napalm-logs you can install it, e.g., pip install napalm-logs[kafka] to pull all the dependencies for you. I have mixed feelings about this sort of tricks as they can lead to confusion, and I think I prefer to let the user decide what's best for them to install. How'd you find that?