react-native-safari-view icon indicating copy to clipboard operation
react-native-safari-view copied to clipboard

Adding new functionalities

Open gilador opened this issue 5 years ago • 3 comments

added in this commit: hide() unhide() isInit()

gilador avatar Jul 31 '19 21:07 gilador

Thank you for your contribution. What would be a use case for this new functionality?

koenpunt avatar Aug 04 '19 08:08 koenpunt

hey, we are using in-app lock screen. in that case the lock screen would be overran by the webview wheres it should be hidden.

On Sun, 4 Aug 2019 at 11:59, Koen Punt [email protected] wrote:

Thank you for your contribution. What would be a use case for this new functionality?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/naoufal/react-native-safari-view/pull/109?email_source=notifications&email_token=AB7MTVKCSHLY7B7YEXV7JR3QC2K7NA5CNFSM4IIKRCTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3P5ORQ#issuecomment-517986118, or mute the thread https://github.com/notifications/unsubscribe-auth/AB7MTVLB2X72EAJAYCCAYXTQC2K7NANCNFSM4IIKRCTA .

-- גילעד אור,Gilad or

gilador avatar Aug 04 '19 17:08 gilador

I don't feel much for adding the functionality of hiding the view, since it's a too specific use case, and some would even call it a hack.

And for the isInit method, wouldn't it be more efficient to keep track of that in the JS code of where you're consuming this library?

koenpunt avatar Apr 06 '20 12:04 koenpunt