react-native-payments icon indicating copy to clipboard operation
react-native-payments copied to clipboard

Update list of supported Google Pay gateways.

Open barbieri opened this issue 6 years ago • 9 comments

There are more gateways, not just braintree and stripe.

barbieri avatar May 05 '18 21:05 barbieri

I had to update the list to use a different gateway, however it may be good to not call validateGateway(), instead let the API be called and return a failure if it's unsupported... this will avoid problems like I had... being more extensible as Google will likely add more partners.

barbieri avatar May 05 '18 21:05 barbieri

Are these gateways supported by default on Android? No need to setup SDKs for those addons?

Andreyco avatar May 10 '18 22:05 Andreyco

There is no need for an SDK if all you do is to get the reply (ie: paymentToken) and send to your server.

For instance I use firstdata (PayEezy): https://developer.payeezy.com/payeezy-api/apis/post/transactions-18 and its 3DS field is basically what comes in paymentToken:

Payeezy's 3DS:

{
    "signature": "...",
    "type": "G",
    "version": "ECv1",
    "data": "{\"encryptedMessage\":\"...\",\"ephemeralPublicKey\":\"...\",\"tag\":\"...\"}"
  }

React-Native-Payment's getPaymentToken() results:

{
  "signature": "...",
  "protocolVersion": "ECv1",
  "signedMessage": "{\"encryptedMessage\":\"...\",\"ephemeralPublicKey\":\"...\",\"tag\":\"...\"}"
}

barbieri avatar May 11 '18 19:05 barbieri

ping?

barbieri avatar Jun 19 '18 15:06 barbieri

This should be merged, otherwise there is no way to integrate almost all gateways from available list as mentioned @barbieri.

kirillpisarev avatar Dec 14 '18 10:12 kirillpisarev

Hey @barbieri , thanks so much for this PR, especially your follow up comments. I understand that the functionality of Google Pay is pretty different from Apple Pay and this needs a re-think. I'm maintaining this library and studying a bit, will get back to this soon.

nabilfreeman avatar Nov 17 '20 23:11 nabilfreeman

@kirillpisarev are you around? This was a long time ago but would like to know if this is still the right way to approach supporting gateways for Google Pay.

nabilfreeman avatar Dec 01 '20 14:12 nabilfreeman

@nabilfreeman i wish i could help you, but i can't remember the point of the issue and i don't have access to the source code of the project i was working on...

kirillpisarev avatar Dec 15 '20 08:12 kirillpisarev

As far as i remember the supported gateways could be omitted, because the list actually is pretty big and there is no reason to keep it in the code

kirillpisarev avatar Dec 15 '20 08:12 kirillpisarev