react-native-activity-view icon indicating copy to clipboard operation
react-native-activity-view copied to clipboard

Can't build on RN 0.32 (LoadImageWithTag removed)

Open samuelkraft opened this issue 9 years ago • 5 comments

LoadImageWithTag was deprecated a while ago and removed with rn 0.32. It is now not possible to build with Xcode anymore.

samuelkraft avatar Aug 29 '16 14:08 samuelkraft

No workaround yet? I need to send an update to the store, and this is the only lib I can't get to work

Edit: Nevermind. Here: https://github.com/naoufal/react-native-activity-view/pull/56/files

ammichael avatar Sep 15 '16 22:09 ammichael

thnks @ammichael but now I get the following error

Exception '-[__NSCFString _setProperty:forKey:]: unrecognized selector sent to instance 0x7fd9615b8ab0' was thrown while invoking show on target ActivityView with params ( { imageUrl = "<imagelink>"; text = "<sample text>"; } ) using RN 0.33

ismdcf avatar Sep 23 '16 06:09 ismdcf

@ismdcf actually the PR is not mine. I just changed the same line, in the same file, and worked like a charm.

About your error, seems like the problem is something in your code (but hey, I may be wrong)

ammichael avatar Sep 23 '16 13:09 ammichael

@ismdcf Not sure if you solved the issue, but it looks like loadImageWithURLRequest requires an NSURLRequest, and the existing code passes an NSString, causing the error.

This code fixes the issue:

NSURL *url = [NSURL URLWithString:imageUrl]; NSURLRequest *request = [[NSURLRequest alloc] initWithURL:url]; [loader loadImageWithURLRequest:request callback:^(NSError *error, id imageOrData) {

digitalcatnip avatar Oct 03 '16 01:10 digitalcatnip

yep it did not work .Tk @digitalcatnip It now works .

ismdcf avatar Oct 03 '16 04:10 ismdcf