Method name "get_pixelsize_meters" does not follow the conventions

[mortenwh]

It should be get_pixel_size_meters, right...?

[BabikerM]

I will work on this.

[korvinos]

@mortenwh @akorosov @BabikerM I would suggest making it a property. Then we could call it by my_object.pixel_size. The units can be specified in the documentation. It will solve the issue @mortenwh addressed and also make it shorter.

[mortenwh]

Sounds like a plan!

On Tue, Apr 30, 2019 at 11:06 AM Artem Moiseev [email protected] wrote:

@mortenwh https://github.com/mortenwh @akorosov https://github.com/akorosov I would suggest making it a property. Then we could call it by my_object.pixel_size. The units can be specified in the documentation. It will solve the issue @mortenwh https://github.com/mortenwh addressed and also make it shorter.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nansencenter/nansat/issues/379#issuecomment-487872927, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA2UBM2AA57MLTTFWQ7R63PTADZRANCNFSM4FUUWRTQ .

-- T.: (+47) 915 47 844

[mortenwh]

@BabikerM - can you implement this? Remember tests...

[BabikerM]

I worked on both issues 375 and 379, when i made the pull request I got "The Travis CI build failed". any suggestions how to solve that?

[mortenwh]

Why did you delete the pull request? It hasn't been merged, and there are some things to do still...

[BabikerM]

I think it happened by mistake when trying to merge the other branches.

[mortenwh]

Ok - maybe you accidentally deleted your branch? Then you'll have to restart this... It should anyway not take toomuch time