ops icon indicating copy to clipboard operation
ops copied to clipboard

consider gating builds for osx passing tests

Open eyberg opened this issue 3 years ago • 2 comments

osx is definitely a preferred target, albeit with it's warts, i think the nightlies are set to run on osx but not every build https://github.com/nanovms/ops/pull/733

eyberg avatar Nov 04 '20 19:11 eyberg

we do have ci builds for osx https://github.com/nanovms/ops/blob/master/.circleci/config.yml#L29 - not sure if this is necessary anymore?

eyberg avatar Jul 31 '21 02:07 eyberg

Even though we have a "build-mac" CI job in config.yml, it's not being run at every commit, only the Linux build job is being run. We would need to specify the Mac build explicitly in the commit workflow, similar to what the Nanos config.yml file does; something like:

workflows:
  commit-workflow:
    jobs:
      - build
      - build-mac

francescolavra avatar Jul 31 '21 06:07 francescolavra