nanogallery2 icon indicating copy to clipboard operation
nanogallery2 copied to clipboard

Toolbars hiding improvements

Open lucav76 opened this issue 4 years ago • 4 comments

This patch provides two functionalities intended to improve the hiding of the toolbars.

  1. Until now, if the user keeps moving the mouse, the toolsbars where hidden and then shown again. This is not an expected behavior, as in general they should stay out until the user moves the mouse, and the hide. This is achieve with a new method, debounceMulti(), which can keep postponing the requested method call until required.
  2. In addition, there can be cases where there is some external logic that should prevent the toolbars from hiding. My use case is adding a panel next to the right or left arrow; in this case, as long as the mouse is on the panel, I don't want the tollbars (and my panel!) to disappear.

Apart from the patch, please consider this two issues:

  1. This page does not work anymore: https://nano.gallery/lic/lic.php

I would like to buy a license very soon, I am just waiting to incorporate a company. 2) jquery.nanogallery2.core.js has mixed line endings (on my computer with my settings, 183 lines end with "\n" while the rest use "\r\n"). This make it annoying to contribute a patch. If you can fix this issue, it would be good.

And thank you for your work: nanogallery is great!

lucav76 avatar Dec 28 '20 23:12 lucav76

@lucav76 many thanks for your PR, it'll be included in the next release.

I'll check the issue with \n and \r\n (I don't know where this comes from...). Thanks for reporting.

The licence page has been replaced since some weeks. The new one is: https://nano.gallery/lic/lic.html Is there still a link to the old one on the site ?

Kris-B avatar Dec 29 '20 23:12 Kris-B

Thanks to you. :-) And yes, https://nanogallery2.nanostudio.org/ still points to the old page

lucav76 avatar Dec 30 '20 09:12 lucav76

Works for me, thanks

BillTheGoat avatar Feb 19 '21 18:02 BillTheGoat

@Kris-B I didn't see this included in the release, are some changes required?

ajmeese7 avatar May 14 '23 17:05 ajmeese7