shaman icon indicating copy to clipboard operation
shaman copied to clipboard

Vendoring doesn't work on a fork.

Open rugwirobaker opened this issue 5 years ago • 5 comments

When I tried to build a fork of the project in my own CI and my laptop it could not find the packages. Example: main.go:46:2: cannot find package "github.com/nanopack/shaman/api" in any of: /home/travis/gopath/src/github.com/rugwirobaker/shaman/vendor/github.com/nanopack/shaman/api (vendor tree) /home/travis/.gimme/versions/go1.9.linux.amd64/src/github.com/nanopack/shaman/api (from $GOROOT)

rugwirobaker avatar Nov 28 '18 10:11 rugwirobaker

It maybe a beginner's issue but please help me I think I like this project.

rugwirobaker avatar Nov 28 '18 10:11 rugwirobaker

Solved local build with help from this post

rugwirobaker avatar Nov 28 '18 11:11 rugwirobaker

etcd clientv3 dependencies don't seem to work well with govendor. I am trying to integrate etcd as a backend but when I try to build after having created a simple etcd client as according to the the etcd README example it fails(more in the referenced issue). I have successfully build after having replaced govendor with dep. How to you recommend I proceed??

ref: https://github.com/etcd-io/etcd/issues/10288#issue-385597736

rugwirobaker avatar Nov 30 '18 13:11 rugwirobaker

I think moving to dep is a good move. Would you mind creating a PR that switches to dep?

Once that’s merged into master you should be good to continue here.

Thank you! This is excellent work.

tylerflint avatar Nov 30 '18 14:11 tylerflint

right away chief.

rugwirobaker avatar Nov 30 '18 14:11 rugwirobaker