logvac icon indicating copy to clipboard operation
logvac copied to clipboard

Spamming "Redialing Datadog"

Open sdomino opened this issue 5 years ago • 2 comments

After each message gets published we're setting the connection to nil here

Because of this, each time another publish comes in, we're creating a new connection and outputting "Redialing Datadog" here

This could probably be optimized a bit, however, I don't think there is anything inherently wrong with it, we probably just don't need that output message.

sdomino avatar Aug 01 '18 16:08 sdomino

It's actually setting the connection to nil only if there was an error writing on the connection, so it will know to redial. I'd say get rid of the log message though.

glinton avatar Aug 01 '18 18:08 glinton

You're right, I misread that initially. For some reason, I read it err == nil. I'll have another look and see where it's causing the spam

sdomino avatar Aug 01 '18 19:08 sdomino